[RFC][icedtea-web]: PR658 - jnlp.{pack,version}Enabled

[Omair Majid]

On 03/04/2011 02:14 PM, Denis Lila wrote:
> One more thing. In the patch I also try to implement versionEnabled.
>
> I now think we should get rid of this, since it doesn't seem
> to be supported for applets:
> http://download.oracle.com/javase/6/docs/technotes/guides/jweb/tools/pack200.html#versionDownload
>

I would leave it in; it might be one less issue after we add in better 
support for using JNLPs with plugins.

> Also, I have one more question:
> If this all looks good, should it be pushed as one changeset?

Separate changesets please.

> I'm uneasy about that since there seem to be at least 4 different
> issues I try to fix here:
> 1. the jar == ajar issue (which could easily be broken for non-plugin
> files too, if they created new JARDesc objects in getResources(Class<T>)
> 2. The naming of packed files to .pack.gz instead of .jar.pack.gz
> (unrelated to the plugin).
> 3. Checking for "gzip".equals(con.getContentEncoding()) before checking
> for pack200 and gzip encoding (again, unrelated to plugin).
> 4. And the main bug: the lack of implementation of packEnabled
> for plugins (fixed by the instanceof).
>
> Should I break it up?

Yes, please.

Cheers,
Omair