[RFC][icedtea-web]: PR658 - jnlp.{pack,version}Enabled

Denis Lila dlila at redhat.com
Fri Mar 4 15:16:33 PST 2011

> Is it possible to split this into two patches? It would be nice to fix
> the bugs in the current system in a separate patch than one which adds
> plugin support for packEnabled.

Sure. I've attached the patches. packEnabledp1.patch is the first one,
and packEnabledp2.patch is the second one.

> Makes sense. Good catch!

Thanks :D

> Ugh. I really dont like the explicit checks for PluginBridge. I
> suppose
> that's ok for now, but when we start fixing applets deployed through
> JNLPs things will become much more interesting.

I was uncomfortable with this too. I think I found a good way to fix it
using polymorphism.

> You might be able to simplify this code. We only need this loop
> because
> JNLPs have different resources sections and each section gets to
> specify
> packEnabled and versionEnabled (at least, that's how I understand it);
> this loop finds the right resources section. For the plugin, we dont
> have resources sections, so we can do the check outside the loop.
> There
> should be no need for the URL.equals() either then.

The above allowed me to not make any changes to how we get the
DownloadOptions for jnlp applications (that aren't applets).
I just needed to move the body of the DL option getter to JNLPFile.java.

Ok to push now?

Thank you,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: packEnabledp1.patch
Type: text/x-patch
Size: 4927 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110304/d319f3de/packEnabledp1.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: packEnabledp2.patch
Type: text/x-patch
Size: 5991 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110304/d319f3de/packEnabledp2.patch 

More information about the distro-pkg-dev mailing list