Reviewer needed - really simple correction of regression test hotspot/test/gc/6581734/Test6581734

[Dr Andrew John Hughes]

On 15:07 Fri 04 Mar     , Pavel Tisnovsky wrote:
> > 
> > Well it doesn't by default, but I see your point.
> > 
> > Please post a patch against 1.9 that applies when hs19 is used (WITH_ALT_HSBUILD)
> > and include an appropriate NEWS update pointing to the PR.
> > 
> Hi Andrew,
> 
> hg diff created against recent IcedTea6-1.9 version is stored in
> attachment (including new info in NEWS pointing to PR and S bugs -
> mentioned S-bug can not be found ATM but I'm pretty sure it existed as
> I pushed this change to JDK7 using this number).
> 

$ hg log -R ../upstream/jdk6/hotspot -k 6980392
changeset:   1998:e760899a624f
user:        kevinw
date:        Fri Aug 27 16:57:04 2010 +0100
summary:     6980392: TEST_BUG: gc/6581734/Test6581734.java has typo

It exists there so I'm happy enough. Their bug database is proprietary
and does crazy things.

> And here is Changelog entry:
> 
> 2011-03-04  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>         * Makefile.am: Add new patch.
>         * patches/openjdk/6980392-fix_test6581734.patch:
>         Testcase correction - added missing right bracket.
> 
> Can you please review it?

Your ChangeLog needs to mention the NEWS changes and
the NEWS item should be under 'Backports'.  Good to
go for 1.9 with those fixes.

> 
> Thank you in advance,
> Pavel

> diff -r e71c8f4ba044 Makefile.am
> --- a/Makefile.am	Thu Feb 24 16:31:02 2011 +0100
> +++ b/Makefile.am	Fri Mar 04 15:00:42 2011 +0100
> @@ -345,7 +345,8 @@
>  if WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += \
>  	patches/openjdk/6994130-ppc_fix.patch \
> -	patches/hotspot/hs19/ia64-fix.patch
> +	patches/hotspot/hs19/ia64-fix.patch \
> +	patches/openjdk/6980392-fix_test6581734.patch
>  else
>  ICEDTEA_PATCHES += \
>  	patches/shark_do_nothing_on_stub_frame.patch \
> diff -r e71c8f4ba044 NEWS
> --- a/NEWS	Thu Feb 24 16:31:02 2011 +0100
> +++ b/NEWS	Fri Mar 04 15:00:42 2011 +0100
> @@ -13,6 +13,8 @@
>  * Backports
>    - S6675802: Regression: heavyweight popups cause SecurityExceptions in applets
>    - S6691503: Malicious applet can show always-on-top popup menu which has whole screen size 
> +* Fixes
> +  - S6980392, PR642: simple correction in testcase, added missing bracket
>  

It should be listed under backports.

>  New in release 1.9.7 (2011-02-15):
>  
> diff -r e71c8f4ba044 patches/openjdk/6980392-fix_test6581734.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/openjdk/6980392-fix_test6581734.patch	Fri Mar 04 15:00:42 2011 +0100
> @@ -0,0 +1,11 @@
> +--- /dev/null	2010-10-08 22:29:24.000000000 +0200
> ++++ openjdk/hotspot/test/gc/6581734/Test6581734.java	2010-11-11 15:47:15.000000000 +0100
> +@@ -121,7 +121,7 @@
> +         }
> + 
> +         if (collectorsWithTime<collectorsFound) {
> +-            throw new RuntimeException("collectors found with zero time";
> ++            throw new RuntimeException("collectors found with zero time");
> +         }
> +         System.out.println("Test passed.");
> +     }


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37