Reviewer needed - patches to remove wrong regression tests hotspot/test/compiler/6987555/Test6987555 and hotspot/test/compiler/6991596/Test6991596

[Dr Andrew John Hughes]

On 12:05 Mon 07 Mar     , Omair Majid wrote:
> On 03/07/2011 11:53 AM, Pavel Tisnovsky wrote:
> > Hi all,
> >
> > I'd like add two patches to remove two regression tests, namely
> > hotspot/test/compiler/6987555/Test6987555 and
> > hotspot/test/compiler/6991596/Test6991596, from IcedTea6 HEAD, because
> > these tests are based on presence of JSR-292 which is not part of OpenJDK6.
> >
> 
> Makes sense to me.
> 

Is this in both hs19 & hs20?  If not, the patches need to be conditional.

> > Here's Changelog entry:
> >
> > 2011-03-07  Pavel Tisnovsky<ptisnovs at redhat.com>
> >
> >
> >
> >          * Makefile.am: Added two new patches.
> >
> >          * patches/jtreg-remove-test-6987555.patch:
> >
> >          Patch to remove regression test
> >
> >          hotspot/test/compiler/6987555/Test6987555
> >
> >          which is not valid for OpenJDK6
> >
> >          * patches/jtreg-remove-test-6991596.patch:
> >
> >          Patch to remove regression test
> >
> >          hotspot/test/compiler/6991596/Test6991596
> >
> >          which is not valid for OpenJDK6
> >
> >
> 
> Some unneeded spacing between lines here.
> 
> > Diff created against recent IcedTea6 HEAD is stored in attachment.
> >
> > Can anybody review this change please?
> >
> 
> Can you please add a description to the patch file (similar to the 
> descriptions in patches produced by hg export) that mentions the reason 
> for removing the tests.
> 
> Other than that, it looks good to me.
> 
> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37