Reviewer needed - patches to remove wrong regression tests hotspot/test/compiler/6987555/Test6987555 and hotspot/test/compiler/6991596/Test6991596

Omair Majid omajid at redhat.com
Mon Mar 7 12:21:29 PST 2011


On 03/07/2011 02:41 PM, Dr Andrew John Hughes wrote:
> On 19:34 Mon 07 Mar     , Dr Andrew John Hughes wrote:
>> On 12:05 Mon 07 Mar     , Omair Majid wrote:
>>> On 03/07/2011 11:53 AM, Pavel Tisnovsky wrote:
>>>> Hi all,
>>>>
>>>> I'd like add two patches to remove two regression tests, namely
>>>> hotspot/test/compiler/6987555/Test6987555 and
>>>> hotspot/test/compiler/6991596/Test6991596, from IcedTea6 HEAD, because
>>>> these tests are based on presence of JSR-292 which is not part of OpenJDK6.
>>>>
>>>
>>> Makes sense to me.
>>>
>>
>> Is this in both hs19&  hs20?  If not, the patches need to be conditional.
>>
>
> Just confirmed these aren't in OpenJDK6:
>
> $ ls ../upstream/jdk6/hotspot/test/compiler/6987555/Test6987555.java
> ls: cannot access ../upstream/jdk6/hotspot/test/compiler/6987555/Test6987555.java: No such file or directory
> $ ls ../upstream/jdk6/hotspot/test/compiler/6991596/Test6991596.java
> ls: cannot access ../upstream/jdk6/hotspot/test/compiler/6991596/Test6991596.java: No such file or directory
>
> So in applying this you'll have broken the build.  Please fix ASAP.
>

Sorry about missing this in the review. In the interest of time, I have 
pushed a changeset that moves the patches to the ALT_HSBUILD section.

> A better fix would have been to rm the files; then it wouldn't matter if they didn't exist or if they changed.
>

Pavel, could you please apply the suggested fix?

Omair



More information about the distro-pkg-dev mailing list