Reviewer needed - fix for IcedTea bug#637

Mark Wielaard mark at klomp.org
Tue Mar 8 02:39:57 PST 2011


Hi Pavel,

On Tue, 2011-03-08 at 10:22 +0100, Pavel Tisnovsky wrote:
> Fixes:
> 
> 1) test names uses $@ macro instead of its full name
> 2) new target is named jtregcheck-summary
> 3) this target is specified as .PHONY
> 4) files check-$$i.log are now touched in a loop where result file is
> generated
> 5) added NEWS entry to ChangeLog
> 
> ChangeLog entry:
> 
> 2011-03-08  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>     * Makefile.am:
>     Added checking of JTreg results - if at least one
>     regression test failed, make exits with error code
>     * NEWS: updated, added PR637 to the list of bug fixes.

Looks good to me.

I see Matthias didn't add a NEWS entry for his change, but it is really
useful. If you are updating the NEWS file anyway could you add something
like:

  And it is now also possible to run individual jtreg testsuite
  (jdk,langtools and hotspot) with the jtreg_checks argument:
  make check jtreg_checks="langtools hotspot"
  If none is provided make check runs all testsuites.

Thanks,

Mark




More information about the distro-pkg-dev mailing list