[RFC][Icedtea-web]: Close streams after opening them.

[Andrew Su]

----- Original Message -----
> From: "Denis Lila" <dlila at redhat.com>
> To: "Andrew Su" <asu at redhat.com>
> Cc: "IcedTea" <distro-pkg-dev at openjdk.java.net>, "Omair Majid" <omajid at redhat.com>
> Sent: Tuesday, March 8, 2011 8:58:10 AM
> Subject: Re: [RFC][Icedtea-web]: Close streams after opening them.
> Hi Andrew.
> 
> What about doing something like this:
> 
> OutputStream s = null;
> try {
> try {
> s = new FileOutputStream(file);
> store(s, header);
> } finally {
> if (s != null) {
> s.close();
> }
> }
> } catch (Exception ex) {
> ex.printStackTrace();
> }
> 
> (and similarly for the InpuStream case).
> 
> This way we don't have to have another try catch block
> inside the finally (which is unpleasant and weird looking),
> we don't have to have more than one printStackTrace call
> to handle the 2 IOExceptions, and we take care of any
> exceptions thrown in "new FileOutputStream(file);" (a point
> brought up by Andrew Haley in another message).

Excellent, that snippet looks much cleaner. However we want the other exceptions that could be thrown to also be thrown back.

Updated patch.

ChangeLog:

2011-03-08  Andrew Su  <asu at redhat.com>

        * netx/net/sourceforge/jnlp/util/PropertiesFile.java:
        (load): Closed streams after opening them.
        (store): Likewise.

Cheers,
 Andrew

> 
> Also, this is closer to what we're trying to do, which is
> returning unused resources, and handling exceptional conditions,
> so it makes sense to have one try...finally block for the former
> and one try...catch for the latter.
> 
> Regards,
> Denis.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110307_close_streams_v5.patch
Type: text/x-patch
Size: 1691 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110308/2d5410c8/20110307_close_streams_v5.patch