[RFC][icedtea-web]: netx - close streams after using them

[Omair Majid]

On 03/08/2011 02:37 PM, Denis Lila wrote:
>> >  The indentation changes make this quite hard to read, but the
>> >  additional
>> >  of the various close() looks fine to me.
> The attached patch ignores whitespace changes. It shows that, indeed,
> nothing changed other than the addition of try{}finally{close}.

Thanks. Make it much easier to see the actual changes.

>
>
> diff -r 6dd840d6a04d netx/net/sourceforge/jnlp/runtime/RhinoBasedPacEvaluator.java
> --- a/netx/net/sourceforge/jnlp/runtime/RhinoBasedPacEvaluator.java	Tue Mar 08 10:11:28 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/runtime/RhinoBasedPacEvaluator.java	Tue Mar 08 14:39:48 2011 -0500
> @@ -142,10 +142,14 @@
>               String line = null;
>               BufferedReader pacReader = new BufferedReader(new InputStreamReader(pacUrl.openStream()));
>               contents = new StringBuilder();
> +            try {

Please move this try block up a line so it immediately follows the 
declaration of pacReader.

Everything else looks fine. Ok to commit with proper whitespaces changes.

Cheers,
Omair