[RFC][icedtea-web]: netx - close streams after using them

Omair Majid omajid at redhat.com
Tue Mar 8 11:57:05 PST 2011


On 03/08/2011 02:51 PM, Denis Lila wrote:
> Hi Omair.
>
> We already discussed this on IRC.
> Ok to push?
>
>
> diff -r d558a9a44d5b ChangeLog
> --- a/ChangeLog	Tue Mar 08 14:48:34 2011 -0500
> +++ b/ChangeLog	Tue Mar 08 14:53:50 2011 -0500
> @@ -1,3 +1,8 @@
> +2011-03-08  Denis Lila<dlila at redhat.com>
> +
> +	* netx/net/sourceforge/jnlp/runtime/RhinoBasedPacEvaluator.java
> +	(getProxies): Add result to cache, not cachedResult.
> +
>   2011-03-08  Denis Lila<dlila at redhat.com>
>
>   	* netx/net/sourceforge/jnlp/browser/FirefoxPreferencesFinder.java
> diff -r d558a9a44d5b netx/net/sourceforge/jnlp/runtime/RhinoBasedPacEvaluator.java
> --- a/netx/net/sourceforge/jnlp/runtime/RhinoBasedPacEvaluator.java	Tue Mar 08 14:48:34 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/runtime/RhinoBasedPacEvaluator.java	Tue Mar 08 14:53:50 2011 -0500
> @@ -102,7 +102,7 @@
>           }
>
>           String result = getProxiesWithoutCaching(url);
> -        addToCache(url, cachedResult);
> +        addToCache(url, result);
>           return result;
>       }
>

Looks good to me.

Cheers,
Omair



More information about the distro-pkg-dev mailing list