[icedtea-web] RFC: add a new autoconf macro IT_FIND_OPTIONAL_JAR

[Omair Majid]

On 03/08/2011 04:05 PM, Dr Andrew John Hughes wrote:
> On 13:30 Tue 08 Mar     , Omair Majid wrote:
>> On 03/08/2011 12:33 PM, Dr Andrew John Hughes wrote:
>>> On 10:44 Tue 08 Mar     , Omair Majid wrote:
>>>> Hi,
>>>>
>>>> The attached patch adds a new autoconf macro IT_FIND_OPTIONAL_JAR. This
>>>> macro can be used to find jars that enable optional features in
>>>> icedtea-web. I will be removing IT_FIND_RHINO_JAR in a separate patch.
>>>>
>>>> I will be using this to add support for junit.jar (for running unit
>>>> tests) as well as tagsoup.jar (for parsing malformed jnlp file).
>>>>
>>>> Any thoughts or comments?
>>>>
>>>> ChangeLog:
>>>>
>>>> 2011-03-08  Omair Majid<omajid at redhat.com>
>>>>
>>>>        * acinclude.m4 (IT_FIND_OPTIONAL_JAR): New macro.
>>>>        * configure.ac: Do not call IT_FIND_RHINO. Use IT_FIND_OPTIONAL_JAR
>>>>        instead.
>>>>
>>>> Cheers,
>>>> Omair
>>>
>>> Good idea.  I assume this is based on IT_FIND_RHINO.  Comments inline.
>>>
>>
>> Updated patch attached.
>>
>> Yes, this is based on IT_FIND_RHINO. I made slight tweaks to it though.
>> IT_FIND_RHINO isnt really happy when you say --with-rhino and rhino is
>> not found (it works properly though if you say --with-rhino=no and rhino
>> is not found)
>>
>
> 'not happy' in what way?  If there's a bug in IcedTea6's macro, it needs fixing.
> If this macro does the job, then it can replace the one in IcedTea6/7 as well.
>

Looks like a bug to me. Removing rhino and attempting to build icedtea6 
(HEAD) fails:

$ sudo rpm -e --nodeps rhino
$ ./autogen.sh && ./configure --disable-bootstrap
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
.... snip ....
checking if a native2ascii binary was specified... no
checking if /usr/lib/jvm/java-openjdk/bin/native2ascii is a valid 
executable... yes
checking whether to include Javascript support via Rhino... not found
configure: error: "A rhino jar was not found in /usr/share/java as 
either rhino.jar or js.jar."

But explicitly saying --with-rhino=no works:

$ ./autogen.sh && ./configure --with-rhino=no --disable-bootstrap
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
...snip...
checking if /usr/lib/jvm/java-openjdk/bin/native2ascii is a valid 
executable... yes
checking whether to include Javascript support via Rhino... no
checking for an OpenJDK source zip... not specified
.... snip ....

The attached patch (for icedtea6 HEAD) is the fix I have used in 
icedtea-web. Or I can add IT_FIND_OPTIONAL_JAR to icedtea{6,7}, if you 
would prefer that.

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea6-rhino-configure.patch
Type: text/x-patch
Size: 453 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110308/dcd734e5/icedtea6-rhino-configure.patch