[icetea-web] RFC: Make testIsResolvable really fail for single host name

[Dr Andrew John Hughes]

On 22:56 Thu 10 Mar     , Mark Wielaard wrote:
> Hi,
> 
> The icedtea-web tests are now run on the build slaves, with nice
> output of how many tests pass/fail.
> http://builder.classpath.org/icedtea/buildbot/waterfall
> (Look at the right under the icedtea-web-* builders)
> 
> As you can see one builder fails one test.
> The reason is that one test tries to resolve the host name
> "icedtea", and expects that to fail. But this builder is
> running in a domain where there actually is a host called
> "icedtea".
> 
> So the following patch changes this test to use a name that
> is much more unlikely to exist for real.
> 
> 
> 2011-03-10  Mark Wielaard  <mark at klomp.org>
> 
> 	* tests/netx/pac/pac-funcs-test.js (testIsResolvable):
> 	Change single host name icedtea to NotIcedTeaHost
> 	to make sure it really isn't resolvable.
> 
> OK to push?
> 

Looks good to me.  Approved.

As I said to Omair at the time, these need to be configurable at runtime IMHO,
rather than being hardcoded.

> Thanks,
> 
> Mark
> 
> diff -r 5454292b3fae tests/netx/pac/pac-funcs-test.js
> --- a/tests/netx/pac/pac-funcs-test.js	Thu Mar 10 15:42:01 2011 -0500
> +++ b/tests/netx/pac/pac-funcs-test.js	Thu Mar 10 22:51:42 2011 +0100
> @@ -100,7 +100,7 @@
>      var tests = [
>          [ true, "icedtea.classpath.org", "icedtea.classpath.org" ],
>          [ true, "classpath.org" ],
> -        [ false, "icedtea" ],
> +        [ false, "NotIcedTeaHost" ],
>          [ false, "foobar.classpath.org" ],
>          [ false, "icedtea.classpath.com" ]
>      ];
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37