Reviewer needed - fix for IcedTea bug#637

[Dr Andrew John Hughes]

On 10:26 Thu 10 Mar     , Pavel Tisnovsky wrote:
> Dr Andrew John Hughes wrote:
> > On 23:09 Tue 08 Mar     , Mark Wielaard wrote:
> >> Hi Andrew,
> >>
> > 
> > I think your name is preferable.  I just don't see the point in
> > splitting this off at all in the way that has been suggested.  All it
> > does is break things.
> > 
> 
> Well there's the reason (mentioned in my previous mails but not
> emphasized). Suppose we have following Makefile:
> 
> Target:	Subtarget1 Subtarget2 Subtarget3
> 	echo "Body of Target is executed"
> 
> Subtarget1:
> 	echo "Body of Subtarget1 is executed"
> 	exit 0
> 
> Subtarget2:
> 	echo "Body of Subtarget2 is executed"
> 	exit 1
> 
> Subtarget3:
> 	echo "Body of Subtarget3 is executed"
> 	exit 0
> 
> If you start build by typing "make" it only run the bodies of Subtarget1
> and Subtarget2, as usual.
> 
> If you start it by "make -k", ALL three subtargets' bodies are executed
> BUT the body of Target is not executed due to error in Subtarget2.
> 
> Now slightly modified Makefile:
> 
> Target:	Subtarget1 Subtarget2 Subtarget3 TargetRealBody
> 
> TargetRealBody:
> 	echo "Body of Target is executed"
> 
> Subtarget1:
> 	echo "Body of Subtarget1 is executed"
> 	exit 0
> 
> Subtarget2:
> 	echo "Body of Subtarget2 is executed"
> 	exit 1
> 
> Subtarget3:
> 	echo "Body of Subtarget3 is executed"
> 	exit 0
> 
> Then this Makefile is started by "make -k", ALL subtarget's bodies are
> executed AND also body of TargetRealBody is executed. In our real
> example it means that summary is always generated even if for example
> hotspot regression test(s) fail.
> 

Yes, ok I get all that.

The problem still exists that there is nothing to sequence TargetRealBody
*AFTER* Subtarget{1,2,3}.  Most notably, make -j5 check would run TargetRealBody
right at the beginning.

You could solve this by having Subtarget{1,2,3} set a stamp which Target depends on.

> Pavel

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37