Reviewer needed - patch which fixes class SunToolkit

[Omair Majid]

On 03/11/2011 09:55 AM, Pavel Tisnovsky wrote:
> Hi all,
>
> I'd like to add new patch to IcedTea6 HEAD. This patch fixes the
> exception which is thrown when Color class (java.awt.Color) is about to
> be opened in PropertyEditor. This change is based on OpenJDK7 sources,
> but I'm unable to determine in which push this changes was made.
>

It was made at some point between b20 [1] and b21 [2]. If you send the 
patch to the jdk6 mailing list, perhaps they will tell you the original 
bug id.

> hg diff generated from recent IcedTea6 HEAD is stored in attachment.
>
> Here is ChangeLog entry:
>
> 2011-03-11  Pavel Tisnovsky<ptisnovs at redhat.com>
>
>      * Makefile.am: Add new patch.
>      * patches/sun-toolkit.patch:
>      Patch which fix the AccessControlException while
>      working with Color class in PropertyEditor
>



>
>
> diff -r 4cbe17b91cc8 Makefile.am
> --- a/Makefile.am	Wed Mar 09 10:50:40 2011 +0100
> +++ b/Makefile.am	Fri Mar 11 15:48:05 2011 +0100
> @@ -326,7 +326,8 @@
>   	patches/openjdk/6934977-MappedByteBuffer.load.patch \
>   	patches/jaxp-serial-version-uid.patch \
>   	patches/jtreg-hotspot-bug-6196102.patch \
> -	patches/jtreg-double-to-string.patch
> +	patches/jtreg-double-to-string.patch \
> +	patches/sun-toolkit.patch
>
>   if WITH_ALT_HSBUILD
>   ICEDTEA_PATCHES += \
> diff -r 4cbe17b91cc8 patches/sun-toolkit.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/sun-toolkit.patch	Fri Mar 11 15:48:05 2011 +0100
> @@ -0,0 +1,12 @@
> +--- openjdk/jdk/src/share/classes/sun/awt/SunToolkit.orig.java	2011-03-11 10:48:29.000000000 +0100
> ++++ openjdk/jdk/src/share/classes/sun/awt/SunToolkit.java	2011-03-11 11:24:33.000000000 +0100
> +@@ -65,8 +65,7 @@
> +
> +     /* Load debug settings for native code */
> +     static {
> +-        String nativeDebug = System.getProperty("sun.awt.nativedebug");
> +-        if ("true".equalsIgnoreCase(nativeDebug)) {
> ++        if (AccessController.doPrivileged(new GetBooleanAction("sun.awt.nativedebug"))) {
> +             DebugSettings.init();
> +         }
> +     };

Looks fine to me.

Cheers,
Omair

[1] 
http://icedtea.classpath.org/hg/openjdk/file/37f131a4a8e7/j2se/src/share/classes/sun/awt/SunToolkit.java
[2] 
http://icedtea.classpath.org/hg/openjdk/file/e2018f79de77/j2se/src/share/classes/sun/awt/SunToolkit.java