[icedtea-web] RFC: fix DESTDIR issues in Makefile

[Omair Majid]

On 03/14/2011 05:43 PM, Dr Andrew John Hughes wrote:
> On 13:45 Mon 14 Mar     , Omair Majid wrote:
>> Hi
>>
>> The attached patch fixes some incorrect uses of DESTDIR in Makefile.am.
>> Following the advice from the GNU DESTDIR docs [1], I have removed all
>> uses of DESTDIR that aren't in the install* and uninstall* targets.
>>
>> ChangeLog:
>>
>> 2011-03-14  Omair Majid<omajid at redhat.com>
>>
>>       * Makefile.am (LAUNCHER_BOOTCLASSPATH, PLUGIN_BOOTCLASSPATH)
>>       (javaws.desktop, itweb-settings.desktop): Remove DESTDIR.
>>
>>
>> Any thoughts or comments?
>>
>> Cheers,
>> Omair
>>
>> [1] http://www.gnu.org/prep/standards/html_node/DESTDIR.html#DESTDIR
>
> Looks fine.  How did these get here in the first place?

They sneaked in through a number of changesets:

changeset:   44:5a9f55d67b50
user:        Omair Majid <omajid at redhat.com>
date:        Fri Nov 19 10:35:27 2010 -0500
summary:     fix Exec, Icon and Encoding in desktop entry files

changeset:   65:6c8e9229bded
user:        Omair Majid <omajid at redhat.com>
date:        Thu Dec 02 10:22:44 2010 -0500
summary:     add desktop entry for itweb-settings

changeset:   126:cb3f89164966
user:        Omair Majid <omajid at redhat.com>
date:        Tue Feb 22 11:47:44 2011 -0500
summary:     Install icedtea-web into a FHS-compliant location

Yes, all mine :(

> I thought I'd mentioned this at review time.
>

I recall you mentioning this in the review for replacing launchers with 
shell scripts (and hence why I wrote this patch), but not earlier. My 
apologies if you pointed it out earlier and I missed it.

Thanks,
Omair