Reviewer needed - patch which fixes class SunToolkit

Pavel Tisnovsky ptisnovs at redhat.com
Wed Mar 16 03:58:05 PDT 2011


Dr Andrew John Hughes wrote:

>>> Do you have a test case for this?
>> Yes, this issue is tested (probably incidentally :-) by a regression
>> test java/beans/PropertyEditor/TestColorClass.java
>>
> 
> And this is already in OpenJDK6?  What issue does it find?

Yes this test is already included in OpenJDK6 (and OpenJDK7). At this
moment this test fails due to AccessControlException thrown while
executing this command:

PropertyEditorManager.findEditor(Color.class);

(this code called static initializer of SunToolkit class when the
exception originate - my patch fixes this issue)

> 
>>> Have you looked at upstreaming it?
>> I sent mail to jdk6-dev mail list last week and ask for bug ID.
>>
> 
> Seen, thanks.
> 
>>> The patch filename is really unhelpful as to what this actually is.
>> Any suggestions please? It would be nice to have original bug ID in the
>> name, of course.
>>
> 
> I'd be able to give some suggestions if I knew the problem :-)

Well the problem is that I'm unable to find a bug assigned to this issue
(or change in OpenJDK7) in a Oracle bug database. I tried to search for
keywords such as "SunToolkit", "Color", "AccessControlException" but
without success.

> 
>>> It needs to be mentioned in NEWS.
>> I'd like to do so but don't know yet the bug ID. Will have to look to
>> Oracle bug database again...
>>
> 
> It can be mentioned without a bug ID and then updated.

Ah, I did not know that, will do it.

Pavel



More information about the distro-pkg-dev mailing list