[RFC][Icedtea-Web]: Enforce cache limit based on deployment.properties

[Andrew Su]

----- Original Message -----
> On 21:03 Sun 20 Mar , Andrew Su wrote:
> > Hello,
> >
> > I have attached a patch which will properly drop the downloaded
> > files into the appropriate directory (temp and perm) inside the
> > cache folder. Where temp will be deleted upon jvm shutdown if no
> > other instances of plugin or javaws is running.
> >
> > I have did some testing with some applets and all seems to work.
> > Another patch for updating itw-settings's cache control should be
> > soon since it currently doesn't check for running instances before
> > allowing for deleting cache (also need to be modified to work with
> > new directory structure).
> >
> > Any comments questions or concerns?
> >
> > Cheers,
> >   Andrew
> 
> This is hard to read in its current state.
> 
> The documentation and formatting changes should each be in their own
> separate patches.
> 
> Please just include the necessary code changes in this patch.

The changes to documentation and formatting was unintentional. I've fixed the patch to only have relavent changes.

Cheers,
  Andrew

> 
> > diff -r 466ad8570145 netx/net/sourceforge/jnlp/cache/CacheEntry.java
> > --- a/netx/net/sourceforge/jnlp/cache/CacheEntry.java Thu Mar 17
> > 15:19:39 2011 -0400
> > +++ b/netx/net/sourceforge/jnlp/cache/CacheEntry.java Sun Mar 20
> > 21:00:02 2011 -0400
> > @@ -162,4 +162,16 @@
> >          properties.store();
> >      }
> >
> > + /**
> > + * Make this file appear in the temp cache folder. Once marked as
> > temp, it
> > + * will remain in temp until we have cleared the cache.
> > + */
> > + public void setTemp() {
> > + File infoFile = CacheUtil.getCacheFile(location, version, "temp");
> > + infoFile = new File(infoFile.getPath() + ".info"); // replace with
> > something that can't be clobbered
> > + properties = new PropertiesFile(infoFile, R("CAutoGen"));
> > + properties.setProperty("isTemp", "true");
> > + properties.store();
> > + }
> > +
> >  }
> > diff -r 466ad8570145 netx/net/sourceforge/jnlp/cache/CacheUtil.java
> > --- a/netx/net/sourceforge/jnlp/cache/CacheUtil.java Thu Mar 17
> > 15:19:39 2011 -0400
> > +++ b/netx/net/sourceforge/jnlp/cache/CacheUtil.java Sun Mar 20
> > 21:00:02 2011 -0400
> > @@ -21,6 +21,7 @@
> >  import java.io.*;
> >  import java.net.*;
> >  import java.nio.channels.FileChannel;
> > +import java.nio.channels.FileLock;
> >  import java.util.*;
> >  import java.security.*;
> >  import javax.jnlp.*;
> > @@ -29,36 +30,37 @@
> >  import net.sourceforge.jnlp.config.DeploymentConfiguration;
> >  import net.sourceforge.jnlp.runtime.*;
> >  import net.sourceforge.jnlp.util.FileUtils;
> > +import net.sourceforge.jnlp.util.PropertiesFile;
> >
> >  /**
> >   * Provides static methods to interact with the cache, download
> > - * indicator, and other utility methods.<p>
> > - *
> > - * @author <a href="mailto:jmaxwell at users.sourceforge.net">Jon A.
> > Maxwell (JAM)</a> - initial author
> > + * indicator, and other utility methods.
> > + * <p>
> > + *
> > + * @author <a href="mailto:jmaxwell at users.sourceforge.net">Jon A.
> > Maxwell
> > + * (JAM)</a> - initial author
> 
> Why the change in formatting here? Should be in another patch.
> 
> >   * @version $Revision: 1.17 $
> 
> These should be removed in a separate patch.

Okay I'll remove these as well (in another patch).

--Snip--

Cheers,
  Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110321_add_cache_limit_v11.patch
Type: text/x-patch
Size: 21206 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110321/7ca13ba9/20110321_add_cache_limit_v11.patch