[icedtea-web] RFC: add unit tests for the jnlp parser

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-03-22 15:09]:
> Hi,
> 
> The attached patch adds unit tests for the JNLP parser to
> icedtea-web. A simple 'make check' should run these tests.
> 
> The unit tests rely on the testng framework. The patch adds optional
> dependencies on testng, qdox and bsh for running these unit tests. I
> have also added a dependency on xlst for transforming the test
> output into a more jtreg-like format (useful for the buildbots)
> 
> I also looked into using junit for these tests, but junit's command
> line output is rather limited. To generate xml output, ant is
> required as well.
> 
> Any thoughts or comments?
>

I'll let Andrew go over the makefile changes. As for the code, it looks
good to me. I got 4 failures. 1 seems to be an error in the test, and
the other 3 are either test errors (exception not caught) or parser
errors (exception shouldn't be thrown in the first place). It seems more
like the former though.. unless our parser is equipped to handle that
kind of bad xml?

<snip> 
> +
> +    @Test
> +    public void testCommentInAttributes() throws ParseException {
> +        String malformedJnlp = "<?xml?><jnlp spec='<!-- something -->'></jnlp>";
> +        Node root = Parser.getRootNode(new ByteArrayInputStream(malformedJnlp.getBytes()));
> +        Parser p = new Parser(null, null, root, false, false);
> +        assertEquals("<!-- something -->", p.getSpecVersion().toString());
> +    }
> +

The above test fails. However I think the test itself might be wrong. If
there is no spec # and there is just a comment instead, shouldn't it
default to 1.0+ (which is what it is doing)?

<snip>
> +
> +    @Test
> +    public void testMalformedArguments() throws ParseException {
> +        String malformedJnlp = originalJnlp.replace("arg2</argument", "arg2<argument");
> +        Parser.getRootNode(new ByteArrayInputStream(malformedJnlp.getBytes()));
> +    }
> +

The above test fails.

> +    @Test
> +    public void testTagNotClosed() throws ParseException {
> +        String malformedJnlp = originalJnlp.replace("</jnlp>", "<jnlp>");
> +        Parser.getRootNode(new ByteArrayInputStream(malformedJnlp.getBytes()));
> +    }
> +

The above test fails.

> +    @Test
> +    public void testUnquotedAttributes() throws ParseException {
> +        String malformedJnlp = originalJnlp.replace("'jnlp.jnlp'", "jnlp.jnlp");
> +        Parser.getRootNode(new ByteArrayInputStream(malformedJnlp.getBytes()));
> +    }
> +

The above test fails.

Cheers,
Deepak