[Bug 676] milliseconds bug in java.sql.Timestamp

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=676





--- Comment #5 from Omair Majid <omajid at redhat.com>  2011-03-23 20:49:30 ---
(In reply to comment #4)
> The methods after() and before() both use the Timestamp.compareTo(). 
> 
> With the fix in compareTo were now the getTime() is used rather then the
> super.compareTo() since this will actually return the the milli-seconds as
> well. So I would have thought your fix addresses my bug perfectly. But I'm
> saying this just from looking at the code, and I maybe missing something.
> 

I just checked; the patch is insufficient to fix the problem in the test case
:(

The test case does startDate.before(timeStamp), that's Date.before(Timestamp).
Date.before() does not invoke Timestamp.compareTo(), so it is not affected by
the patch.

I suppose the simplest fix is to follow the javadoc advice and treat the
inheritance hierarchy as an implementation detail: startDate.getTime() <
timeStamp.getTime() should work.


-- 
Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.