[icedtea-web] RFC: add unit tests for the jnlp parser

[Dr Andrew John Hughes]

On 16:26 Wed 23 Mar     , Deepak Bhole wrote:
> * Omair Majid <omajid at redhat.com> [2011-03-22 15:09]:
> > Hi,
> > 
> > The attached patch adds unit tests for the JNLP parser to
> > icedtea-web. A simple 'make check' should run these tests.
> > 
> > The unit tests rely on the testng framework. The patch adds optional
> > dependencies on testng, qdox and bsh for running these unit tests. I
> > have also added a dependency on xlst for transforming the test
> > output into a more jtreg-like format (useful for the buildbots)
> > 
> > I also looked into using junit for these tests, but junit's command
> > line output is rather limited. To generate xml output, ant is
> > required as well.
> > 
> > Any thoughts or comments?
> >
> 
> I'll let Andrew go over the makefile changes. As for the code, it looks
> good to me. I got 4 failures. 1 seems to be an error in the test, and
> the other 3 are either test errors (exception not caught) or parser
> errors (exception shouldn't be thrown in the first place). It seems more
> like the former though.. unless our parser is equipped to handle that
> kind of bad xml?
> 

Well, before I even look at the patch, I want to be sure all this additional
crap is needed.  I've never even heard of any of these and having them all
as requirements is going to make it less likely that people will run tests.

Are there no simpler solutions?  I do remember junit was fairly self-contained
the last time I used it, but that was circa 2003.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37