/hg/release/icedtea6-1.10: Makefile.am (jtregcheck): Allow setti...

[Dr Andrew John Hughes]

On 14:19 Fri 25 Mar     , Mark Wielaard wrote:
> On Fri, 2011-03-25 at 12:43 +0000, Dr Andrew John Hughes wrote:
> > On 12:22 Fri 25 Mar     , doko at icedtea.classpath.org wrote:
> > > changeset b162f7c4fe64 in /hg/release/icedtea6-1.10
> > > details: http://icedtea.classpath.org/hg/release/icedtea6-1.10?cmd=changeset;node=b162f7c4fe64
> > > author: doko at ubuntu.com
> > > date: Fri Mar 25 13:17:53 2011 +0100
> > > 
> > > 	Makefile.am (jtregcheck): Allow setting which tests to run.
> > > 
> > > 	2011-02-24 Matthias Klose <doko at ubuntu.com>
> > > 
> > > 	 * Makefile.am (jtregcheck): Allow setting which tests to
> > > 	run.
> >
> > Where was this approved? I don't see any review on the mailing lists.
> 
> It was extensively discussed on irc by me, Pavel and Matthias. You were
> even there. 

No I wasn't. But that's irrelevant anyway, as you can't ensure all possible
interested parties were.  And how do you review the decision in the future?

> But next time a little "acked on irc" could be added to the
> patch post.
> 

Are there any IRC logs?  As I recall, we agreed there wouldn't be.

So there is a record of reviews, all patches should be reviewed on the
list so there is no confusion.

> Please only quote relevant parts of the email you are responding to.
> 

The whole e-mail is relevant.

> Thanks,
> 
> Mark
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37