/hg/release/icedtea6-1.8: PR632: 6878713.patch breaks shark zero...

[Dr Andrew John Hughes]

On 14:17 Fri 25 Mar     , Mark Wielaard wrote:
> On Fri, 2011-03-25 at 12:52 +0000, Dr Andrew John Hughes wrote:
> > On 12:30 Fri 25 Mar     , doko at icedtea.classpath.org wrote:
> > > changeset 015d29e3b82a in /hg/release/icedtea6-1.8
> > > details: http://icedtea.classpath.org/hg/release/icedtea6-1.8?cmd=changeset;node=015d29e3b82a
> > > author: doko at ubuntu.com
> > > date: Fri Mar 25 13:25:46 2011 +0100
> > > 
> > > 	PR632: 6878713.patch breaks shark zero build
> > > 
> > > 	2011-02-16 Xerxes Ranby <xerxes at zafena.se> Mark
> > > 	Wielaard <mark at klomp.org>
> > > 
> > > 	 PR632: 6878713.patch breaks shark zero build
> > > 	        * patches/icedtea-stdc-limit-macros.patch
> > > 	(openjdk/hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp):
> > > 	Only define __STDC_LIMIT_MACROS if undefined.
> > > 	        * Makefile.am (ICEDTEA_PATCHES): Add new patch.
> > > 	        * NEWS: Updated.
> > > 
> > Where was this reviewed?
> 
> See this thread:
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-March/013107.html
> 

How is that a review when there is no patch attached?

There is an issue with the patch that needs correcting.  The NEWS entry is filed
under 'Backports' whereas I don't believe this is an upstream backport.  It should
be under 'Bug fixes'.

Has it been tested on both HotSpot configurations in 1.8?

What about 1.9?

> And please only quote the relevant bits in your email.
> 

Again, the whole patch is relevant.  I now can't comment on it because you removed it.

> Thanks,
> 
> Mark
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37