RFC: JamVM - Handle overflow in getPhysicalMemory()

[Dr Andrew John Hughes]

On 23:54 Fri 25 Mar     , Xerxes Ranby wrote:
> The attached patches updates JamVM to handle overflow in getPhysicalMemory()
> http://git.berlios.de/cgi-bin/cgit.cgi/jamvm/commit/?id=a95ca049d3bb257d730535a5d5ec3f73a943d0aa
> 
> This fixes a bug that prevented JamVM to start on 32bit systems with 
> more than 2Gb of RAM.
> 
> IcedTea6-1.10
> Ok to push?
> 
> IcedTea6
> Ok to push?
> 
> Cheers and have a great day!
> Xerxes

Sounds good.  Approved for both.

> Index: icedtea6/ChangeLog
> ===================================================================
> --- icedtea6.orig/ChangeLog	2011-03-25 23:09:42.000000000 +0100
> +++ icedtea6/ChangeLog	2011-03-25 23:12:14.000000000 +0100
> @@ -1,3 +1,11 @@
> +2011-03-25  Xerxes Ranby  <xerxes at zafena.se>
> +
> +	JamVM: Handle overflow in getPhysicalMemory().
> +	* NEWS: Updated.
> +	* Makefile.am
> +	(JAMVM_VERSION): Updated to latest JamVM revision.
> +	(JAMVM_SHA256SUM): Updated.
> +
>  2011-03-25  Pavel Tisnovsky  <ptisnovs at redhat.com>
>  
>  	* Makefile.am: Add new patch.
> Index: icedtea6/Makefile.am
> ===================================================================
> --- icedtea6.orig/Makefile.am	2011-03-25 23:09:42.000000000 +0100
> +++ icedtea6/Makefile.am	2011-03-25 23:10:21.000000000 +0100
> @@ -11,8 +11,8 @@
>  CACAO_URL = $(CACAO_BASE_URL)/$(CACAO_VERSION).tar.gz
>  CACAO_SRC_ZIP = cacao-$(CACAO_VERSION).tar.gz
>  
> -JAMVM_VERSION = cc6997003dd65ba5a32df471b7c0547fba9769f2
> -JAMVM_SHA256SUM = 731f913978d15dd1753ef434b4f237237f37280b07e3d1905e76e8c03034fbde
> +JAMVM_VERSION = a95ca049d3bb257d730535a5d5ec3f73a943d0aa
> +JAMVM_SHA256SUM = 18bb5c97c03fb73f70b481440e3e11803448d327c024d4570a338b899693fefd
>  JAMVM_BASE_URL = http://icedtea.classpath.org/download/drops/jamvm
>  JAMVM_URL = $(JAMVM_BASE_URL)/jamvm-$(JAMVM_VERSION).tar.gz
>  JAMVM_SRC_ZIP = jamvm-$(JAMVM_VERSION).tar.gz
> Index: icedtea6/NEWS
> ===================================================================
> --- icedtea6.orig/NEWS	2011-03-25 23:09:42.000000000 +0100
> +++ icedtea6/NEWS	2011-03-25 23:11:06.000000000 +0100
> @@ -33,6 +33,7 @@
>    - CA157: ARM SMP Assertion thinlock failed.
>  * JamVM
>    - Ignore all unknown options.
> +  - Handle overflow in getPhysicalMemory().
>    - Base default min and max heap size on physical memory.
>    - Fix reflective array access.
>    - Handle O_DELETE in JVM_Open.

> Index: icedtea6-1.10/ChangeLog
> ===================================================================
> --- icedtea6-1.10.orig/ChangeLog	2011-03-25 22:25:23.000000000 +0100
> +++ icedtea6-1.10/ChangeLog	2011-03-25 22:26:51.000000000 +0100
> @@ -1,3 +1,11 @@
> +2011-03-25  Xerxes Ranby  <xerxes at zafena.se>
> +
> +        JamVM: Handle overflow in getPhysicalMemory().
> +        * NEWS: Updated.
> +        * Makefile.am
> +        (JAMVM_VERSION): Updated to latest JamVM revision.
> +        (JAMVM_SHA256SUM): Updated.
> +
>  2011-02-24  Matthias Klose  <doko at ubuntu.com>
>  
>  	* Makefile.am (jtregcheck): Allow setting which tests to run.
> Index: icedtea6-1.10/Makefile.am
> ===================================================================
> --- icedtea6-1.10.orig/Makefile.am	2011-03-25 22:20:23.000000000 +0100
> +++ icedtea6-1.10/Makefile.am	2011-03-25 22:22:28.000000000 +0100
> @@ -11,8 +11,8 @@
>  CACAO_URL = $(CACAO_BASE_URL)/$(CACAO_VERSION).tar.gz
>  CACAO_SRC_ZIP = cacao-$(CACAO_VERSION).tar.gz
>  
> -JAMVM_VERSION = cc6997003dd65ba5a32df471b7c0547fba9769f2
> -JAMVM_SHA256SUM = 731f913978d15dd1753ef434b4f237237f37280b07e3d1905e76e8c03034fbde
> +JAMVM_VERSION = a95ca049d3bb257d730535a5d5ec3f73a943d0aa
> +JAMVM_SHA256SUM = 18bb5c97c03fb73f70b481440e3e11803448d327c024d4570a338b899693fefd
>  JAMVM_BASE_URL = http://icedtea.classpath.org/download/drops/jamvm
>  JAMVM_URL = $(JAMVM_BASE_URL)/jamvm-$(JAMVM_VERSION).tar.gz
>  JAMVM_SRC_ZIP = jamvm-$(JAMVM_VERSION).tar.gz
> Index: icedtea6-1.10/NEWS
> ===================================================================
> --- icedtea6-1.10.orig/NEWS	2011-03-25 22:22:36.000000000 +0100
> +++ icedtea6-1.10/NEWS	2011-03-25 22:24:33.000000000 +0100
> @@ -25,6 +25,7 @@
>    - CA156: uncaughtExceptionHandler doesn't work with OpenJDK 6 b21.
>    - CA157: ARM SMP Assertion thinlock failed.
>  * JamVM
> +  - Handle overflow in getPhysicalMemory().
>    - Base default min and max heap size on physical memory.
>    - Fix reflective array access.
>    - Handle O_DELETE in JVM_Open.


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37