Reviewer needed: fix for class RegularFileObject + added new regression test

[Pavel Tisnovsky]

Hi all,

I've prepared patch which fixes behaviour of RegularFileObject class.
There's a difference between IcedTea6-1.9 and IcedTea6-1.10|HEAD in
path+object(file) name returned by the method JavaFileObject.getName()
which is caused by changes made in OpenJDK's sources by this quite big
and IMHO unclear changeset:
http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/5c2858bccb3f

Here are results for three various IcedTea versions:

IcedTea6-1.9.x output:

Source location: [./data]
JavaFileObject.getName() = Test.html
JavaFileObject.getName() = Test.java
JavaFileObject.getName() = Test.class
JavaFileObject.getName() = Test.txt

Unpatched IcedTea6-HEAD output:

Source location: [./data]
JavaFileObject.getName() = ./test-data/Test.html
JavaFileObject.getName() = ./test-data/Test.java
JavaFileObject.getName() = ./test-data/Test.class
JavaFileObject.getName() = ./test-data/Test.txt

Pathes IcedTea6-HEAD output:

Source location: [./data]
JavaFileObject.getName() = Test.html
JavaFileObject.getName() = Test.java
JavaFileObject.getName() = Test.class
JavaFileObject.getName() = Test.txt



This patch also contains new regression test which checks the proper
behaviour of JavaFileObject and JavaFileManager classes, ie. whether
correct path is returned for four types of file objects:

- java source
- java class (I mean source compiled to bytecode)
- HTML file
- other file (in this case text file)

(three of this files are included in patch, fourth - .class - is
automatically generated by JTreg tool)

FYI: this patch also fixes one TCK failure.

hg diff created against recent IcedTea6 HEAD version is stored in
attachment.

Here's ChangeLog entry:

2011-03-28  Pavel Tisnovsky  <ptisnovs at redhat.com>

    * Makefile.am: Add new patch.
    * patches/regular-file-object-patch:
    Patch which fixes the behaviour of JavaFileManager
    and JavaFileObject classes. This patch also contains
    regression test for check it the fix is correct.


Can anybody review this change please?

Thank you in advance,
Pavel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hg_diff
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110328/5d335800/hg_diff.ksh