[icedtea-web] RFC: Patch to correct classloader sharing rules

[Denis Lila]

> Nope, it is not. The original patch I was working on would have
> resolved
> it, but then I found (this) more elegant solution and opted for that
> as
> it addresses multiple things at once.

Ah, good. In that case, it looks ok to me.

> Feel free to post a patch for the CWD issue.

Thanks, I will.

Regards,
Denis.

----- Original Message -----
> * Denis Lila <dlila at redhat.com> [2011-03-28 13:29]:
> > > Fixed as well. New patch okay?
> >
> > This isn't supposed to fix the problem where a class
> > in the CWD with the same name as the applet one is trying
> > to load will get loaded instead of the applet, right?
> >
> 

> 
> Cheers,
> Deepak
> 
> > Regards,
> > Denis.
> >
> > ----- Original Message -----
> > > * Dr Andrew John Hughes <ahughes at redhat.com> [2011-03-25 20:43]:
> > > > On 19:43 Fri 25 Mar , Deepak Bhole wrote:
> > > > > Hi,
> > > > >
> > > > > Omair found a page earlier that specifies some rules on plugin
> > > > > classloader
> > > > > sharing. Currently we share it based on site address --
> > > > > attached
> > > > > patch fixes
> > > > > that to do it as per the proprietary plugin rules:
> > > > > http://download.oracle.com/javase/6/docs/technotes/guides/deployment/deployment-guide/applet-compatibility.html
> > > > >
> > > > > ChangeLog:
> > > > > 2011-03-25 Deepak Bhole <dbhole at redhat.com>
> > > > >
> > > > >     * netx/net/sourceforge/jnlp/PluginBridge.java
> > > > >     (PluginBridge): Construct unique key based on a
> > > > >     combination of
> > > > >     codebase,
> > > > >     cache_archive, java_archive, and archive. This
> > > > >     automatically
> > > > >     ensures are
> > > > >     loaders are shared only when appropriate.
> > > > >
> > > > > Cheers,
> > > > > Deepak
> > > >
> > > > AFAICS, atts is a hashtable with generic types so the casts
> > > > don't
> > > > need to be there.
> > > >
> > >
> > > Doh! Didn't even think to check for generics.. just went with old
> > > habit
> > > of casting :/ Fixed now.
> > >
> > > > Some of the lines seem too long. I guess there isn't much that
> > > > can
> > > > be done
> > > > with the URL, but the later comments and the String assignments
> > > > could certainly
> > > > be split.
> > > >
> > >
> >
> > >
> > > Cheers,
> > > Deepak