[icedtea-web] RFC: fix broken -J command line arguments

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-03-28 14:58]:
> On 03/28/2011 02:43 PM, Deepak Bhole wrote:
> >* Omair Majid<omajid at redhat.com>  [2011-03-28 14:30]:
> ><snip>
> >>>
> >>>It works with /bin/sh (I tried it with a test script before posting the
> >>>original email).
> >>>
> >>
> >>It works in Fedora (which uses bash as /bin/sh), but not in Debian
> >>(which uses dash as /bin/sh). ${var:index} is a bash extension and
> >>not part of POSIX. Can I revert
> >>http://icedtea.classpath.org/hg/icedtea-web/rev/a640b4e4d226 ?
> >>
> >
> >Ah, I didnt realize re: POSIX. There there is a POSIX solution as well:
> >
> >JAVA_ARGS="${JAVA_ARGS} ${1#-J}"
> >
> >should work.
> >
> 
> Thanks for the solution. Okay to commit?
> 

Yep, okay for head!

Cheers,
Deepak

> Cheers,
> Omair

> diff -r d94fc0fb8a53 launcher/javaws.in
> --- a/launcher/javaws.in	Fri Mar 25 14:23:28 2011 -0400
> +++ b/launcher/javaws.in	Mon Mar 28 14:54:18 2011 -0400
> @@ -7,8 +7,26 @@
>  BINARY_LOCATION=@JAVAWS_BIN_LOCATION@
>  PROGRAM_NAME=javaws
>  
> +JAVA_ARGS=
> +ARGS=
> +
> +while [ "$#" -gt "0" ]; do
> +  case "$1" in
> +    -J*)
> +      JAVA_ARGS="${JAVA_ARGS} ${1##-J}"
> +      ;;
> +    *)
> +      ARGS="${ARGS} $1"
> +      ;;
> +  esac
> +  shift
> +done
> +
>  ${JAVA} ${LAUNCHER_BOOTCLASSPATH} ${LAUNCHER_FLAGS} \
> +  ${JAVA_ARGS} \
>    -Dicedtea-web.bin.name=${PROGRAM_NAME} \
>    -Dicedtea-web.bin.location=${BINARY_LOCATION} \
>    ${CLASSNAME} \
> -  $@
> +  ${ARGS}
> +
> +exit $?