[RFC][netx]: minor fixup

Dr Andrew John Hughes ahughes at redhat.com
Tue Mar 29 07:15:31 PDT 2011


On 10:11 Tue 29 Mar     , Denis Lila wrote:
> Hi.
> 
> Ok to push?
> 
> ChangeLog:
> +2011-03-29  Denis Lila <dlila at redhat.com>
> +
> +	* netx/net/sourceforge/jnlp/JNLPFile.java
> +	(getInformation): Remove redundant if.
> +
> 
> Thank you,
> Denis.

Fine.  You can just commit obvious things like this or typos.

> diff -r c04136b79d4a ChangeLog
> --- a/ChangeLog	Mon Mar 28 15:08:39 2011 -0400
> +++ b/ChangeLog	Tue Mar 29 10:11:17 2011 -0400
> @@ -1,3 +1,8 @@
> +2011-03-29  Denis Lila <dlila at redhat.com>
> +
> +	* netx/net/sourceforge/jnlp/JNLPFile.java
> +	(getInformation): Remove redundant if.
> +
>  2011-03-28  Omair Majid  <omajid at redhat.com>
>  
>  	* launcher/javaws.in: Split out -J arguments and pass it to the JVM.
> diff -r c04136b79d4a netx/net/sourceforge/jnlp/JNLPFile.java
> --- a/netx/net/sourceforge/jnlp/JNLPFile.java	Mon Mar 28 15:08:39 2011 -0400
> +++ b/netx/net/sourceforge/jnlp/JNLPFile.java	Tue Mar 29 10:11:17 2011 -0400
> @@ -329,8 +329,7 @@
>                      InformationDesc infoDesc = info.get(i);
>  
>                      if (localMatches(locale, infoDesc.getLocales()))
> -                        if (localMatches(locale, infoDesc.getLocales()))
> -                            result.addAll(infoDesc.getItems(key));
> +                        result.addAll(infoDesc.getItems(key));
>                  }
>  
>                  return result;


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the distro-pkg-dev mailing list