Reviewer needed: fix for class RegularFileObject + added new regression test

Pavel Tisnovsky ptisnovs at redhat.com
Tue Mar 29 10:00:02 PDT 2011


Hi all,

as Andrew Haley pointed out, my previous fix was not correct because in
POSIX shells functions shall be defined in following way:

foo() {bar; }

and not

function foo {bar; }

nor:

function foo() {bar; }


In the attachment is stored third (and possibly final ;-) version of the
patch which contains fixed shell script and also the part used for
deletion of outdated regression test:
openjdk/langtools/test/tools/javac/api/6411310/Test.java


Here is ChangeLog entry:

2011-03-29  Pavel Tisnovsky  <ptisnovs at redhat.com>

        * patches/revert-6885123.patch:
        Fixed test shell script to work on POSIX shells.
        This patch also deletes now defunct regression
        test:
        openjdk/langtools/test/tools/javac/api/6411310/Test.java


Can anybody please review this change?

If you think this patch is correct, I'll prepare version for
IcedTea6-1.10 too.


Thank you in advance,
Pavel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hg_diff
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110329/02861683/hg_diff.ksh 


More information about the distro-pkg-dev mailing list