[icedtea-web] RFC: Use a simple gui dialog to indicate errors in launching applications

[Denis Lila]

Looks good to me.

Then again, I'm not hugely familiar with swing, so it would
be nice to have another review (of the ExceptionDialog file
in particular).

Regards,
Denis.

----- Original Message -----
> Hi,
> 
> The attached patch adds a new GuiLaunchHandler class which uses gui
> elements to display exceptions that occur when launching JNLP
> applications. This is only used if not running in headless mode.
> Something different will be needed for the plugin.
> 
> Not all exceptions are caught by this - some parsing exceptions can
> occur in Boot. I will be posting fixes for those later.
> 
> I have also moved the splash screen stuff into this class as it makes
> no
> sense to have it run in headless mode.
> 
> Any thoughts or comments?
> 
> ChangeLog:
> 
> 2011-03-29 Omair Majid <omajid at redhat.com>
> 
> * netx/net/sourceforge/jnlp/LaunchHandler.java
> (launchInitialized, launchStarting): New methods.
> * netx/net/sourceforge/jnlp/DefaultLaunchHandler.java
> (launchInitialized, launchStarting): New methods. No-op
> implementation.
> * netx/net/sourceforge/jnlp/GuiLaunchHandler.java: New file.
> (launchCompleted, launchError, launchStarting, launchInitialized),
> (launchWarning, validationError): New methods.
> * netx/net/sourceforge/jnlp/Launcher.java (launchApplication):
> Invoke handler.launchInitialized and handler.launchStarting instead
> of showing a splash screen directly.
> * netx/net/sourceforge/jnlp/resources/Messages.properties: Add
> ButShowDetails, ButHideDetails and Error.
> * netx/net/sourceforge/jnlp/runtime/Boot.java (run): Do not exit on
> error.
> * netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java
> (initialize): Set handler to GuiLaunchHandler if not running in
> headless mode.
> * netx/net/sourceforge/jnlp/util/BasicExceptionDialog.java: New
> file.
> (exceptionToString, show): New methods.
> 
> Cheers,
> Omair