[RFC][plugin]: fix fixme

[Denis Lila]

> Are we not worried about the identifiers going into negatives?

At first I didn't think this would be possible without running
out of memory first, but looking at it again, you're right - in
very rare cases it is possible to not run out of memory and still
have that function return a negative number (but none of these
cases are possible right now, since we don't really dereference
anything). Still, it's good to guard against all possibilities.

I've attached the improved patch.

Regards,
Denis.

----- Original Message -----
> ----- Original Message -----
> > Hi.
> >
> > This patch implements the fixme in PluginObjectStore
> > using the "wrapped" idea in that comment. It also
> > synchronizes modifications to the 3 hash maps because,
> > afaics, they can be called concurrently.
> >
> > ChangeLog:
> > +2011-03-30 Denis Lila <dlila at redhat.com>
> > +
> > + * plugin/icedteanp/java/sun/applet/PluginObjectStore.java
> > + (wrapped): New static variable.
> > + (getNextID): New function.
> > + (reference): Using getNextID and synchronized.
> > + (unreference): Synchronized.
> > + (dump): Improve iteration.
> >
> > Any criticism is always welcome.
> >
> > Thank you,
> > Denis.
> 
> Hi Denis,
> 
> + if (wrapped)
> + while(objects.containsKey(nextUniqueIdentifier))
> + nextUniqueIdentifier++;
> + return nextUniqueIdentifier++;
> + }

> I think there's an extra space before the return.
> 
> Other than that, the patch looks ok to me.
> 
> Cheers,
> Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hg.diff
Type: text/x-patch
Size: 4423 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110330/a4475c0b/hg.diff