[RFC][plugin]: fix fixme

Deepak Bhole dbhole at redhat.com
Wed Mar 30 12:59:42 PDT 2011


* Denis Lila <dlila at redhat.com> [2011-03-30 10:42]:
> > Are we not worried about the identifiers going into negatives?

Replying here to this and previous msg.

re 25 days -- you're right, I missed the 24h. That said, the allocation
rate I used was also 20x+ higher than average, so it is still
unrealistic that it will get there. My only concern with changing for
these sort of cases is that we are modifying known stable code for
something that has never happened and will probably never happen.

Nonetheless..

<snip>
> +    private int getNextID() {
> +        // TODO: we may want to count the number of iterations in this
> +        // loop. If we're wasting too much time there, throw some error
> +        // to indicate that we need to switch to longs.

I am not sure what you mean by the TODO. Switch to long when? while it
is running? That wouldn't be possible after the HashMap has been
initialized with int...

If extra passes here are a concern, we should switch to long from the
start. I don't think that is necessary though.

Rest looks fine to me. Okay for commit after removing above TODO.

Cheers,
Deepak



More information about the distro-pkg-dev mailing list