[icedtea-web] RFC: fix explanation for JDK_UPDATE_VERSION in makefile

Deepak Bhole dbhole at redhat.com
Wed Mar 30 13:08:55 PDT 2011


* Omair Majid <omajid at redhat.com> [2011-03-30 16:03]:
> Hi,
> 
> The attached patch fixes the explanation for JDK_UPDATE_VERSION in
> Makefile.am. The JDK_UPDATE_VERSION does not affect the plugin
> detector; the plugin detector still complains about an out-of-date
> plugin. Updating the JDK_UPDATE_VERSION is also not required if
> Oracle releases a JDK update past 50.
> 
> Okay to commit?
> 
> Cheers,
> Omair

> diff -r d78bbff25267 Makefile.am
> --- a/Makefile.am	Tue Mar 15 10:22:27 2011 -0400
> +++ b/Makefile.am	Thu Mar 17 18:26:40 2011 -0400
> @@ -28,8 +28,8 @@
>  LAUNCHER_BOOTCLASSPATH="-Xbootclasspath/a:$(datadir)/$(PACKAGE_NAME)/netx.jar$(RHINO_RUNTIME)"
>  PLUGIN_BOOTCLASSPATH='"-Xbootclasspath/a:$(datadir)/$(PACKAGE_NAME)/netx.jar:$(datadir)/$(PACKAGE_NAME)/plugin.jar$(RHINO_RUNTIME)"'
>  
> -# Fake update version to shut up the plugin detector hosted by Oracle.
> -# If Oracle ever release a JDK update greater than 50, this needs to be increased.
> +# Fake update version to work with the Deployment Toolkit script used by Oracle
> +# http://download.oracle.com/javase/tutorial/deployment/deploymentInDepth/depltoolkit_index.html
>  JDK_UPDATE_VERSION=50
>  
>  # Sources list

Er, ignore my previous email. I guess you are only trying to fix the
comment :)

Okay for HEAD.

Cheers,
Deepak



More information about the distro-pkg-dev mailing list