[icedtea-web] RFC: fix explanation for JDK_UPDATE_VERSION in makefile

[Dr Andrew John Hughes]

On 16:59 Wed 30 Mar     , Omair Majid wrote:
> On 03/30/2011 04:42 PM, Dr Andrew John Hughes wrote:
> > On 16:02 Wed 30 Mar     , Omair Majid wrote:
> >> Hi,
> >>
> >> The attached patch fixes the explanation for JDK_UPDATE_VERSION in
> >> Makefile.am. The JDK_UPDATE_VERSION does not affect the plugin detector;
> >> the plugin detector still complains about an out-of-date plugin.
> >> Updating the JDK_UPDATE_VERSION is also not required if Oracle releases
> >> a JDK update past 50.
> >>
> >
> > It does? Last time I tried it didn't, but it's a long time since I've tested the plugin.
> >
> 
> Yes, I just confirmed it. The plugin detector shows "Version 6 Update 
> 22". I suppose it does the equivalent of 
> System.getProperty("java.version") to find out the version.
> 

Ah!!! So it used to work because the IcedTea build used it and still does.

We can fake it in IcedTea instead.

Replacing:

JDK_UPDATE_VERSION = $(shell echo $(OPENJDK_VERSION) | sed -e "s/^b//")

with

JDK_UPDATE_VERSION = 99

may be a good idea...

> > I always wondered why it was 50 and not 99 but if it doesn't matter anyway...
> 
> Yeah, I dont think it matters. You can see a human-readable version of 
> the Deployment Toolkit script at http://www.java.com/js/deployJava.txt 
> (licensed under what looks like a 3-clause BSD license). It obtains 
> version strings from plugin mime types and it says "Version strings are 
> of the form #.#[.#[_#]]". So it needs to see something after the 1.6.0_ 
> to identify it as a valid JRE version.
> 

Ok.

> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37