[icedtea-web] RFC: handle exceptions during boot

[Omair Majid]

On 03/30/2011 04:40 PM, Dr Andrew John Hughes wrote:
> On 15:54 Wed 30 Mar     , Omair Majid wrote:
>> Hi,
>>
>> The attached patch makes the LaunchHandler handle exceptions that happen
>> during the parsing of the JNLP file.
>>
>> Most of the changes are simply moving things from Boot to Launcher.
>> Launcher, which has an associated LaunchHandler, is in a much better
>> position to use the LaunchHandler to inform the user about exceptions
>> that happen while parsing.
>>
>> I am not too happy about the name of the class InformationToMerge. Any
>> ideas?
>>
>
> It suggests to me it doesn't warrant being an object.
>
> Any particular reason you need a class at all and didn't just use an
> array or a map, given they all have the same type?
>
> So with a Map<String[]>, extra.getParameters() would become extra.get("parameters")
> and there's room for further expansion with minimal effort.
>

Good point. Fixed in the attached patch.

Any other suggestions or comments?

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: handle-parsing-exceptions-02.patch
Type: text/x-patch
Size: 13310 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110330/a6f74b2a/handle-parsing-exceptions-02.patch