[icedtea-web] RFC: add unit tests for the jnlp parser

[Omair Majid]

On 03/30/2011 08:21 PM, Dr Andrew John Hughes wrote:
> On 20:08 Wed 30 Mar     , Omair Majid wrote:
>
> snip...
>
>>>>>
>>> There does need to be something in there such as:
>>>
>>> // Based on code from X (C) Y
>>>
>>
>> Sure, except I dont know the copyright owners. So I have left it as:
>> // Based on code from JUnit
>>
>
> They don't have license headers?
>

No, they don't. For example, take a look at 
https://github.com/KentBeck/junit/blob/master/src/main/java/org/junit/runner/JUnitCore.java. 
I had to look at other programs to find the CPL header.

>>
>> I think it's a build-time dependency, not a run-time dependency. But you
>> are correct - the tree is quite big.
>>
>
> Same difference on Gentoo.  Everything is built from source.
>

Yes, but for distributions that supply pre-built packages, the 
dependencies are much smaller. On Fedora, for example, it's just 3 
packages - TestNG, QDox, and BeanShell.

>>
>> Updated patch attached. Any thoughts or comments?
>>
>
> Looks fine.  If it passes make distcheck, it can go in.
>

It does. Thanks for reviewing it. I will be pushing it shortly.

> It does need documenting in README, but I'm happy for that to be a separate patch.
>

Thanks; the patch was getting quite big.

Thanks again for all your comments and suggestions.

Cheers,
Omair