Reviewer needed - patch which fixes class SunToolkit for IcedTea6-1.10

[Dr Andrew John Hughes]

On 12:42 Thu 31 Mar     , Pavel Tisnovsky wrote:
> Hi all,
> 
> I'd like to backport SunToolkit patch to IcedTea6-1.10 (it's already
> pushed to IcedTea6 HEAD). Can anybody please review it?
> 
> 2011-03-31  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>     * Makefile.am: Add new patch.
>     * NEWS: Updated (added info about new fix).
>     * patches/mark_sun_toolkit_privileged_code.patch:
>     Patch which fixes the AccessControlException while
>     working with Color class in a PropertyEditor.
> 
> Pavel T.

Backport looks fine, assuming it builds.  Please commit.

Was there any response from Oracle as to the bug ID?  I didn't see anything.

> diff -r 2b50c801e31b Makefile.am
> --- a/Makefile.am	Sat Mar 26 08:27:56 2011 +0100
> +++ b/Makefile.am	Thu Mar 31 12:40:10 2011 +0200
> @@ -325,7 +325,8 @@
>  	patches/pr600-arm-jvm.cfg.patch \
>  	patches/jaxp-serial-version-uid.patch \
>  	patches/openjdk/7023591-AAShapePipe.patch \
> -	patches/openjdk/7027667-AAShapePipeRegTest.patch
> +	patches/openjdk/7027667-AAShapePipeRegTest.patch \
> +	patches/mark_sun_toolkit_privileged_code.patch
>  
>  if WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += \
> diff -r 2b50c801e31b NEWS
> --- a/NEWS	Sat Mar 26 08:27:56 2011 +0100
> +++ b/NEWS	Thu Mar 31 12:40:10 2011 +0200
> @@ -14,6 +14,7 @@
>  * HotSpot 20 updated to b11.
>  * Backports
>    - S7023591, S7027667: Clipped antialiased rectangles are filled, not drawn.
> +  - Add missing privileged block around access to the sun.awt.nativedebug property.
>  * CACAO
>    - Ignore all unknown options, but report them.
>    - Fixes build for newer gcc (at least 4.4) on PPC64, breaks older gcc.
> diff -r 2b50c801e31b patches/mark_sun_toolkit_privileged_code.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/mark_sun_toolkit_privileged_code.patch	Thu Mar 31 12:40:10 2011 +0200
> @@ -0,0 +1,12 @@
> +--- openjdk/jdk/src/share/classes/sun/awt/SunToolkit.orig.java	2011-03-11 10:48:29.000000000 +0100
> ++++ openjdk/jdk/src/share/classes/sun/awt/SunToolkit.java	2011-03-11 11:24:33.000000000 +0100
> +@@ -65,8 +65,7 @@
> +
> +     /* Load debug settings for native code */
> +     static {
> +-        String nativeDebug = System.getProperty("sun.awt.nativedebug");
> +-        if ("true".equalsIgnoreCase(nativeDebug)) {
> ++        if (AccessController.doPrivileged(new GetBooleanAction("sun.awt.nativedebug"))) {
> +             DebugSettings.init();
> +         }
> +     };


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37