[RFC][plugin]: fix fixme

[Deepak Bhole]

* Denis Lila <dlila at redhat.com> [2011-03-31 12:34]:

> diff -r 3bbc4314e02c ChangeLog
> --- a/ChangeLog	Tue Mar 29 10:24:31 2011 -0400
> +++ b/ChangeLog	Thu Mar 31 09:52:47 2011 -0400
> @@ -1,3 +1,13 @@
> +2011-03-31  Denis Lila  <dlila at redhat.com>
> +
> +	* plugin/icedteanp/java/sun/applet/PluginObjectStore.java
> +	(wrapped, lock): New static variables.
> +	(getNextID, checkNeg): New functions.
> +	(reference): Using getNextID and synchronized.
> +	(dump): Improve iteration and synchronized.
> +	(unreference, getObject, getIdentifier, contains(Object),
> +	contains(int)): Synchronized.
> +
>  2011-03-29  Denis Lila <dlila at redhat.com>
>  

Because the lock is static, this still suffers from the issue Andrew
brought up yesterday, which is that PluginObjectStore is not a
guaranteed singleton. I would make the lock non-static. Same for
wrapped.

The remaining changes look fine to me.

> diff -r 93fe9a7cb5ab ChangeLog
> --- a/ChangeLog	Thu Mar 31 09:53:15 2011 -0400
> +++ b/ChangeLog	Thu Mar 31 10:06:15 2011 -0400
> @@ -1,3 +1,24 @@
> +2011-03-31  Denis Lila  <dlila at redhat.com>
> +
> +	* plugin/icedteanp/java/sun/applet/AppletSecurityContextManager.java
> +	* plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
> +	* plugin/icedteanp/java/sun/applet/GetWindowPluginCallRequest.java
> +	* plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java
> +	* plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
> +	* plugin/icedteanp/java/sun/applet/PluginCookieInfoRequest.java
> +	* plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java
> +	* plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java
> +	* plugin/icedteanp/java/sun/applet/PluginObjectStore.java
> +	* plugin/icedteanp/java/sun/applet/PluginProxyInfoRequest.java
> +	* plugin/icedteanp/java/sun/applet/PluginProxySelector.java
> +	* plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> +	* plugin/icedteanp/java/sun/applet/RequestQueue.java
> +	* plugin/icedteanp/java/sun/applet/VoidPluginCallRequest.java:
> +	Change all instances of PluginDebug.debug(arg1 + arg2 + ...)
> +	to PluginDebug.debug(arg1, arg2, ...).
> +	* plugin/icedteanp/java/sun/applet/PluginDebug.java:
> +	Change debug from "void debug(String)" to "void debug(Object...)". 
> +
>  2011-03-31  Denis Lila  <dlila at redhat.com>
>  
>  	* plugin/icedteanp/java/sun/applet/PluginObjectStore.java


This is a good catch. One minor indentation issue here though:

>  
> -    public static void debug(String message) {
> -        if (DEBUG)
> -            System.err.println(message);
> +    public static void debug(Object... messageChunks) {
> +        if (DEBUG) {
> +        	for (Object chunk : messageChunks) {
> +                System.err.println(chunk.toString());
> +        	}
> +        }
>      }
>  }


The above doesn't seem to adhere to 4-line indent style:
http://icedtea.classpath.org/wiki/IcedTea-Web#Code_style

After fixing the above, second patch is okay for commit to head.

Cheers,
Deepak