[RFC][plugin]: fix fixme

Deepak Bhole dbhole at redhat.com
Thu Mar 31 10:46:27 PDT 2011


> > >  
> > 
> > Because the lock is static, this still suffers from the issue Andrew
> > brought up yesterday, which is that PluginObjectStore is not a
> > guaranteed singleton. I would make the lock non-static. Same for
> > wrapped.
> > 
> 
> Just noticed that the hashmaps and nextUniqueIdentifier are static too
> :/ Please commit with non-static lock and wrapped for now. I will work
> on a patch to make this a singleton so we can later switch lock and
> wrapped to static and guarantee it won't be an issue. 
> 

On second thought, making them non-static would be redundant in this case
anyway. Just commit the patch as is for now then please.

Cheers
Deepak



More information about the distro-pkg-dev mailing list