[icedtea-web] RFC: add unit tests for the jnlp parser

Dr Andrew John Hughes ahughes at redhat.com
Thu Mar 31 11:26:51 PDT 2011


On 13:40 Thu 31 Mar     , Omair Majid wrote:
> On 03/30/2011 08:21 PM, Dr Andrew John Hughes wrote:
> >
> > It does need documenting in README, but I'm happy for that to be a separate patch.
> >
> 
> Patch attached. Does that look okay?
> 
> Thanks,
> Omair

It's a bit brief.

* What about documenting the --with-rhino/junit options?
* What about something specific about the JUnit tests?

Also, typo 'depdencies' instead of 'dependencies'.

> diff -r 77ac95466baa README
> --- a/README	Wed Mar 30 11:47:41 2011 -0400
> +++ b/README	Thu Mar 31 13:40:18 2011 -0400
> @@ -66,6 +66,11 @@
>  
>  The plugin can be disabled by passing --disable-plugin.
>  
> +The following optional depdenencies enable additional features
> +
> +* rhino (enables support for using proxy auto config files)
> +* junit4 (enables unit tests)
> +
>  See ./configure --help if you need to override the defaults.
>  
>  The following locations are checked for a JDK:
> @@ -117,6 +122,9 @@
>  Testing
>  =======
>  
> +A set of tests is supplied for icedtea-web. They can be run by using
> +'make check'.
> +
>  A test suite is supplied for the browser plugin.  It can be built
>  using 'make plugin-tests' and run by loading the HTML page specified
>  into a browser with the plugin installed.


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the distro-pkg-dev mailing list