[icedtea-web] RFC: Patch to fix applet exit

[Denis Lila]

> This patch addresses an issue cause by the tg.stop() call in
> PluginAppletViewer.appletClose().
> 
> With the recent classloader sharing changes, applets from the same
> page
> have the same threadgroup. As a result if 2 copies are opened and one
> is
> closed, the other one stops too.
> 
> With this patch, tg.stop() is no longer called and instead, the plugin
> will halt the VM after the last applet to guarantee that resources are
> freed eventually (the tg.stop was added because not all applets exit
> nicely on stop/dispose).

Is it possible for an applet creation to be racing with the
applet close? I'm thinking, what happens if we're handling an
applet creation but we haven't called the PAV constructor yet?
(so, suppose we're still in parse() and haven't called
factory.createPanel yet).

In that case, wouldn't we just shut down the vm, because
we haven't added the PAV to appletPanels yet and so
0==countApplets()? Isn't this wrong?

Regards,
Denis.

----- Original Message -----
> Hi,
> 

> ChangeLog:
> 2011-05-02 Deepak Bhole <dbhole at redhat.com>
> 
> * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
> (appletClose): Do not try to stop threads, now that the loader is
> shared
> and the thread group for applets on a page is identical. Call dispose
> from
> invokeAndWait.
> (appletSystemExit): Exit the VM when called.
> 
> Okay for HEAD and 1.1?
> 
> Cheers,
> Deepak