[RFC][netx]: fix memory leak introduced by my previous changeset.
Omair Majid
omajid at redhat.com
Mon May 2 14:29:54 PDT 2011
On 05/02/2011 04:47 PM, Denis Lila wrote:
> Hi.
>
> I just realized that my previous changeset was not ideal.
> It created a new thread group object for every NetxPanel,
> but it only created any threads in that thread group if
> a thread group had not already been created for that panel.
>
> This can result in creating unused ThreadGroups. That's
> not a problem by itself - the problem is that they're not
> garbage collected even if they're unused (because they're
> created with a non null parent, and the parent keeps track
> of them in an internal list). This is effectively a (very small)
> memory leak.
>
> The patch to fix this is attached. It just replaces the
> concurrent map with synchronized statements.
>
> Ok to push?
>
Looks fine to me.
Cheers,
Omair
More information about the distro-pkg-dev
mailing list