[RFC][Icedtea6]: Update jpegclasses.patch

[Dr Andrew John Hughes]

On 14:52 Mon 02 May     , Andrew Su wrote:
> Hello,
> 
> In the patch in repo, it is missing a lot of the methods specified by the javadoc.[1]
> Thanks to Matthew Flaschen and marathon who posted some code at [2], but it was still missing a bunch of other stuff.
> I have taken the code posted and fixed it to match the specification by the javadoc as closely as possible, also adding proper documentations where possible, however there is still loads of stub methods, which needs implementation.
> 
> What this patch will add:
> src/share/classes/com/sun/image/codec/jpeg/ImageFormatException.java : Signals that an Image Format exception of some sort has occurred.
> src/share/classes/com/sun/image/codec/jpeg/JPEGCodec.java: Factory class for getting the encoder, decoder, or parameter.
> src/share/classes/com/sun/image/codec/jpeg/JPEGDecodeParam.java : Interface for decoder parameters.
> src/share/classes/com/sun/image/codec/jpeg/JPEGEncodeParam.java : Interface for encoder parameters.
> src/share/classes/com/sun/image/codec/jpeg/JPEGHuffmanTable.java : Huffman table implementation for JPEG. [3]
> src/share/classes/com/sun/image/codec/jpeg/JPEGImageDecoder.java : Interface for implementing JPEG decoder.
> src/share/classes/com/sun/image/codec/jpeg/JPEGImageEncoder.java : Interface for implementing JPEG encoder.
> src/share/classes/com/sun/image/codec/jpeg/JPEGQTable.java : Quantization table implementation for JPEG. [3]
> src/share/classes/com/sun/image/codec/jpeg/TruncatedFileException.java : Signals that a truncated file was detected.
> src/share/classes/sun/awt/image/codec/JPEGImageDecoderImpl.java : Actual implementation of decoder.
> src/share/classes/sun/awt/image/codec/JPEGImageEncoderImpl.java : Actual implementation of encoder.
> src/share/classes/sun/awt/image/codec/JPEGParam.java : Implementation for both encoder and decoder parameters.
> 
> What it will do:
> Keep compatibility with older code that uses the com.sun.image.codec.jpeg.* classes.
> Allow users to encode and decode JPEG images with standard tables.
> 
> What needs to be done:
> Add implementation for stubs.
> For implementation this should end up as a kind of wrapper for the Java Image I/O stuff. [4]
> 
> Attached:
> changeset.patch : patch for updating jpegclasses.patch
> SampleMain.java : Sample for encoding JPEG image at 0.5 quality.
> 
> I've tested building it on head and running a sample piece of code for encoding JPEG images.
> However testing with the encoding test file at [2] it doesn't seem to be able to do it for the buffered image provided. (This shows with his version as well, I haven't been able to pinpoint why..)
> But it's a start to have some basic functionality and a basis to work with.
> 
> Cheers,
>   Andrew
> 
> 
> [1] http://download.oracle.com/javase/1.5.0/docs/guide/2d/api-jpeg/com/sun/image/codec/jpeg/package-summary.html
> [2] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=192
> [3] http://www.w3.org/Graphics/JPEG/itu-t81.pdf
> [4] http://download.oracle.com/javase/6/docs/technotes/guides/imageio/index.html

I haven't looked at the code itself, but I think this would be much more maintainable if it used the overlays
mechanism instead, with possibly a minimal patch to enable building of the code.  I assume the com.sun.image.codec.jpeg
code is not present in the OpenJDK6 tarball?
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37