RFC: Replace gcc-stack-markings.patch in icedtea6 with upstream's fix

Omair Majid omajid at redhat.com
Thu May 5 14:43:41 PDT 2011


On 05/04/2011 03:23 PM, Dr Andrew John Hughes wrote:
> On 14:21 Wed 04 May     , Omair Majid wrote:
>> The attached patch for icedtea6 replaces
>> patches/gcc-stack-markings.patch with the fix applied upstream [1].
>> Instead of adding an elf section named .note.GNU-stack, upstream chose
>> to explicitly indicate to the linker that the stack should be marked as
>> non-executable. There should be no functional change as a result of
>> applying this patch (well, unless your linker doesnt support -z
>> noexecstack ...).
>>
>> The reason I am applying this is to remove custom patches from icedtea6
>> and to bring icedtea6 and icedtea7 closer together.
>>
>> Any thoughts or comments? doko, since you committed the original patch,
>> do you have any particular concerns?
>>

I pinged doko on IRC and he is fine with this change too.

>> [1] http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/dddc5753c53a
>
> I vaguely recall the upstream fix now.  Please commit this.
>

Vaguely recall? It was just a few days ago ;)

Also, since it's just replacing one patch with another, do you think we 
should have a NEWS entry?

Thanks,
Omair



More information about the distro-pkg-dev mailing list