RFC: move patches/headers-hotspot.patch to patches/ecj/

[Omair Majid]

On 05/05/2011 08:53 PM, Dr Andrew John Hughes wrote:
> On 18:29 Thu 05 May     , Omair Majid wrote:
>> Hi,
>>
>>   From what I can tell, patches/headers-hotspot.patch and the associated
>> Makefile.am declerations are only needed during bootstrap (to make sure
>> a proper XML implementation is available). After OpenJDK has been built
>> once, the JDK's build-in implementation should be more than sufficient
>> to perform needed tasks. I have been testing the attached patch and it
>> works fine with and without --disable bootstrap.
>>
>> Does anyone have any thoughts about this?
>>
>> ChangeLog:
>> 2011-05-05  Omair Majid<omajid at redhat.com>
>>
>>     * Makefile.am
>>     (ICEDTEA_PATCHES): Move headers-hotspot.patch to ...
>>     (ICEDTEA_ECJ_PATCHES): Here.
>>     (ICEDTEA_ENV): Moves endorsed dir varaibles to ...
>>     (ICEDTEA_ENV_ECJ): Here.
>>     * patches/headers-hotspot.patch: Move to ...
>>     * patches/ecj/headers-hotspot.patch: New file.
>>
>> Cheers,
>> Omair
>
> Yes, these look like bootstrap patches that have been wrongly placed eons
> ago.  Please apply this.

On looking at this again, I am slightly confused as to how it was 
working at all originally (and I know it was working originally because 
fedora carries a custom patch [1] that adds another file to the endorsed 
directory and the build picks it up). ICEDTEA_ENV is inherited by 
ICEDTEA_ENV_ECJ but the patches are not. So the headers-hotspot.patch 
was applied to only second stage of a bootstrap build. At that point, 
the just-built icedtea6 (built using gcj) should have all the XML 
API/implementation needed (and the custom fedora patch would not have 
made any difference). I am probably missing something here.

> Can you also do a similar change for 7?  The fragment
> is part of headers.patch there and needs to be split and placed in patches/boot.
>

Yeah, I was going to this for IcedTea7 after the fix for IcedTea6 had 
gone through. Thanks for reminding me. Patch for IcedTea7 attached.

Thanks,
Omair

[1] 
http://pkgs.fedoraproject.org/gitweb/?p=java-1.6.0-openjdk.git;a=commitdiff;h=1a4e9b3b26466723002599803257bf51c350b825;hp=d5040e6da68dcbf73ff15df67c28e4fef517a373
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea7-move-jvmti-endorsed-to-boot-01.patch
Type: text/x-patch
Size: 2839 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110506/db90b922/icedtea7-move-jvmti-endorsed-to-boot-01.patch