Fwd: Re: [icedtea-web] xml output for junit, transformation sheets for daily report

[Dr Andrew John Hughes]

On 18:32 Mon 09 May     , Jiri Vanek wrote:
> Clean was missing in previous post:
> @@ -485,6 +502,8 @@
>   	rm -f $(JUNIT_RUNNER_JAR)
> 
>   clean-netx-unit-tests:
> +	rm -rf $(TESTS_STYLES_DIR)
> +	rm -f $(TESTS_DIR)/index.html
>   	rm -f netx-unit-tests-source-files.txt
>   	rm -rf $(NETX_UNIT_TEST_DIR)
>   	rm -f stamps/netx-unit-tests-compile.stamp
> 

And this is for???

Please post patches with some explanation of what they are intended for.

> and changelog:
> 
> 
> 2011-05-09  Jiri Vanek  <jvanek at redhat.com>
> 
> 	* tests/junit-runner/JunitLikeXmlOutputListener: This listener exports
> 	results of junit in xml which "follows junit-output schema". Extended
> 	for date, duration and some statististics for future purpose
> 	* tests/junit-runner/CommandLine.java: added usage of
> 	JunitLikeXmlOutputListener added skipping of inner classes and one
> 	jnlp file from sources package.

The inner class handling should be a separate patch, as it has nothing to do with this,
other than being a prerequisite.

> 	*index.html: file which provides runtime transformation
> 	of tests-output.xml and report.xml
> 	* tests/styles/index.js: runtime transformation script and fast
> 	navigation functions

I think the transformation should be preformed by make as part of producing index.html,
rather than having browser-specific hacks.

> 	* tests/styles/report.css: styles for transformed result
> 	* tests/styles/jreport.xsl: template for human-readable xml->html
> 	transformation.
> 
> 

Also you seem to include @author tags in the Java code.  I didn't realise we had
a standard for doing this.  Do we?  Either way, 'jvanek' is not very identifiable.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37