[icedtea-web] reviewer needed - added engine for lunching reproducers

[Jiri Vanek]

On 05/07/2011 01:32 AM, Omair Majid wrote:
> Hi Jiri,
>
> On 05/05/2011 12:05 PM, Jiri Vanek wrote:
>> Makefile - automated compile and copy for most of reproducers, with
>> possibility to add more complex reproducers which will take care of
>> compiling themselves (I have in this way also "repaired" your
>> reproducers you send me, but because this patch is about engine itself
>> they are not commited - but are working quite fine :) )
>> When all reproducers are prepared, junit testsuite is lunched - after
>> program is "installed". junit takes location of installed javaws and
>> location of prepared reproducers (directory jars, jnlps and other
>> resources).
>>
>> Inside junit suite virtual server is lunched and serves all resources.
>> During the testsuite individual jnlps are executed, and their
>> stderr/out/return code can be asserted. (There are helepers method for
>> this in used virtual server which provides to tester exactly std out/err
>> return code). Also possibility to timeout process is added.
>> At the end the report - same as was for unit tests - is generated (if my
>> previous patch is used :). There is also possibility of including
>> stdout/err of tests into xml-report files.
>>
>
> Sorry for taking so long to respond to this.
>
> I have got to admit, this is great! I have lots of little nitpicks [1],
> but we can argue about those _after_ you commit an initial version.
>
> I only thing I dont like is how test information is spread out. I would
> love if this was more jtreg-like: you place everything (jnlp file and
> the associated java file (and possibly a makefile or other meta
> information)) in one directory. I dont like that you have to add junit
> test methods (to another location). You have a big thumbs up from me if
> you can fix this.
>
> Thanks again for doing this!
>
> Cheers,
> Omair
>
> [1] including file paths/names, variable names, spacing and other
> details ;)

So another round - partially based on attached communication.
The heart of patch is not changed at all. It automatically compile and 
deploy individual reproducers. Still containing space for more complex 
reproducers which compile and(or) deploy themselves. Run testsuite 
inside junit, and contains small server (can run several instances on 
different port, and contains helping methods) as singleton and lunches 
by-make installed javaws.

The crucial difference is in testing whether reproducer passed or 
failed. In previous patch this was included ind 
tests/dist/net/sourceforge/  (acording to tests/unit/net/sourceforge). 
Now (as previewd in simpletest 1 and 2 reproducer) each reproducer have 
except srcs and resources directory also testcases  directory which 
contains javaclass which will be added to junit testsuit to be lunched 
and examined. (*** _I'm not sure about package hierarchy here_ ***). 
Those testcases have tests/dist on their classpath even during compile, 
so they can use helpers functions and server smoothly.

regards J.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: j-reproducers_engine.patch
Type: text/x-patch
Size: 31822 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110511/be235d14/j-reproducers_engine.patch 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: redhat-#java.log
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110511/be235d14/redhat-java.log