Reviewer needed - fix for regression test test/sun/net/www/protocol/file/DirPermissionDenied in IcedTea7

[Omair Majid]

On 05/12/2011 11:46 AM, Pavel Tisnovsky wrote:
> Hi all,
>
> I'd like to add new simple patch to IcedTea7 which fixes regression test
> test/sun/net/www/protocol/file/DirPermissionDenied. Currently this test
> creates unreadable directory (chmod a-r, more precisely chmod 333) and
> this directory (which is not empty btw.) is not erased when the test
> finishes (command rm -rf does not work in this case).
>
> So I added command which restores +w flag for given user (chmod u+r) and
> then the directory and its contents could be properly deleted.
>

I am assuming you meant "restores +r flag".

> Tested on: recent IcedTea7 on RHEL 5 x86_64
>

Any chance you could try and convince upstream OpenJDK to accept this?

>
> Here is ChangeLog entry:
>
> 2011-05-12  Pavel Tisnovsky<ptisnovs at redhat.com>
>
>          * Makefile.am: Added new patch.
>          * patches/jtreg-DirPermissionDenied-fix.patch:
>          Patch for regression test DirPermissionDenied -
>          this test should clean all files and directories
>          created during its run.
>
> Can anybody please review this patch?
>
> Thank you in advance,
> Pavel T.
>
>
> hg_diff
>
>
> diff -r 5ffa85bf891c Makefile.am
> --- a/Makefile.am	Thu May 05 01:17:33 2011 +0100
> +++ b/Makefile.am	Thu May 12 16:38:17 2011 +0200
> @@ -357,7 +357,8 @@
>   	patches/boot/hotspot-jdk-dependency.patch \
>   	patches/boot/ecj-multicatch.patch \
>   	patches/boot/ecj-trywithresources.patch \
> -	patches/boot/ecj-autoboxing.patch
> +	patches/boot/ecj-autoboxing.patch \
> +	patches/jtreg-DirPermissionDenied-fix.patch
>

This should not be added to the boot patch list (ICEDTEA_BOOT_PATCHES). 
Please add it to ICEDTEA_PATCHES instead. Whether a patch is applied to 
the bootstrap jdk is determined by the path in the patch file - so this 
patch will affect the non-bootstrapped JDK. But the patch will only be 
applied on boostrap builds.

>   if CP39408_JAVAH
>   ICEDTEA_BOOT_PATCHES += patches/boot/pr39408.patch
> diff -r 5ffa85bf891c patches/jtreg-DirPermissionDenied-fix.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/jtreg-DirPermissionDenied-fix.patch	Thu May 12 16:38:17 2011 +0200
> @@ -0,0 +1,9 @@
> +--- openjdk.orig/jdk/test/sun/net/www/protocol/file/DirPermissionDenied.sh	2011-05-12 16:04:01.000000000 +0200
> ++++ openjdk/jdk/test/sun/net/www/protocol/file/DirPermissionDenied.sh	2011-05-12 15:57:32.000000000 +0200
> +@@ -37,5 +37,6 @@
> +
> + $TESTJAVA/bin/java -classpath $TESTCLASSES DirPermissionDenied ${TESTDIR}
> + result=$?
> ++chmod u+r ${TESTDIR}
> + rm -rf ${TESTDIR}
> + exit $result