Reviewer needed: second fix for regression hotspot test

Pavel Tisnovsky ptisnovs at redhat.com
Thu May 12 09:11:49 PDT 2011


Chris Phillips wrote:
> On 12/05/11 11:44 AM, distro-pkg-dev-request at openjdk.java.net wrote:
>> ----------------------------------------------------------------------

Hi Chris,

> This also works on RH linux with appropriate finagling of yum and libries:
>  210 % ./i586/jdk1.7.0/bin/java -version
> java version "1.7.0-ea"
> Java(TM) SE Runtime Environment (build 1.7.0-ea-b137)
> Java HotSpot(TM) Server VM (build 21.0-b07, mixed mode)
>  211 % arch
> x86_64

yeah, I tried this test against 32-bit proprietary Oracle JDK 6/7 on
RHEL 5 x86_64. I just forgot to mention this.

> 
> 
> Looking at the patch ( not sure if it qualifies as a review ;)
> 
> <snip>
> 
> This :
> 
>  +  i585)
>  +    ARCH=i386
> 
> 
> probably wants to be
> 
>  +  i586)
>        _
>  +    ARCH=i386
> 
sure ;-) my fault.

> Otherwise looks OK to me .

Thank you Chris, I'll send new version of patch to another review.

> 
> Cheers!
> Chris
> 




More information about the distro-pkg-dev mailing list