Reviewer needed - fix for regression test test/sun/net/www/protocol/file/DirPermissionDenied in IcedTea7

[Dr Andrew John Hughes]

On 17:46 Thu 12 May     , Pavel Tisnovsky wrote:
> Hi all,
> 
> I'd like to add new simple patch to IcedTea7 which fixes regression test
> test/sun/net/www/protocol/file/DirPermissionDenied. Currently this test
> creates unreadable directory (chmod a-r, more precisely chmod 333) and
> this directory (which is not empty btw.) is not erased when the test
> finishes (command rm -rf does not work in this case).
> 
> So I added command which restores +w flag for given user (chmod u+r) and
> then the directory and its contents could be properly deleted.
> 
> Tested on: recent IcedTea7 on RHEL 5 x86_64
> 
> 
> Here is ChangeLog entry:
> 
> 2011-05-12  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>         * Makefile.am: Added new patch.
>         * patches/jtreg-DirPermissionDenied-fix.patch:
>         Patch for regression test DirPermissionDenied -
>         this test should clean all files and directories
>         created during its run.
> 
> Can anybody please review this patch?
> 
> Thank you in advance,
> Pavel T.

As mentioned in http://icedtea.classpath.org/wiki/CommitPolicy IcedTea7
patches are applied to the IcedTea forest, not to IcedTea7 itself.  For 2.0, all
patches will be removed from IcedTea7. See:

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=712

Also, this patch is wrong anyway as it adds the patch as a bootstrapping patch.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37