RFC: replace rmi_amd64.patch with upstream's fix in icedtea6

Omair Majid omajid at redhat.com
Thu May 12 10:32:29 PDT 2011


On 05/12/2011 01:19 PM, Dr Andrew John Hughes wrote:
> On 12:52 Thu 12 May     , Omair Majid wrote:
>> Hi,
>>
>> Upstream has applied an improved version of patches/rmi_amd64.patch. I
>> would like to add that patch to icedtea6 and remove rmi_amd64. Patch is
>> attached.
>>
>> Not sure if I should add a NEWS entry or not. I have left it out for now.
>>
>> ChangeLog
>> 2011-05-12  Omair Majid<omajid at redhat.com>
>>
>>     * Makefile.am (ICEDTEA_PATCHES): Remove rmi_amd64.patch. Add
>>     7043921-java_rmi_cgi.patch
>>     * patches/openjdk/7043921-java_rmi_cgi.patch: New file.
>>     * patches/rmi_amd64.patch: Remove.
>>
>> Any comments or concerns?
>>
>> Cheers,
>> Omair
>
> Looks fine to me.  Thanks for tracking this one down.
>

Thank _you_ for reviewing the patch.

> I agree it doesn't need a NEWS entry as nothing has actually changed.
>

Actually the behaviour on solaris-64 has. solaris-64 had duplicate 
copies of java-rmi.cgi (in bin/ and sparv9/bin/) (I have not verified 
this myself). Which is why the original check for 32 bit arch was added. 
This fix makes sure that on linux java-rmi.cgi is always placed in bin/ 
and on solaris-64 it is not.

Anyway, I have pushed the fix.

Cheers,
Omair



More information about the distro-pkg-dev mailing list