RFC: drop patches/tools.patch from icedtea6

[Dr Andrew John Hughes]

On 16:20 Thu 12 May     , Omair Majid wrote:
> On 05/06/2011 06:37 PM, Omair Majid wrote:
> > Hi,
> >
> > The attached patch drops patches/tools.patch from icedtea6.
> >
> > tools.patch consists of 2 parts: the first part modifies
> > jdk/make/tools/sharing/classlist.$(PLATFORM) and the other modifies
> > jdk/make/java/awt/Makefile.
> >
> > As described in jdk/make/tools/sharing/README.txt, classlist.$(PLATFORM)
> > is the class list used in class data sharing (-Xshare). The patch
> > removes DebugHelper and DebugHelperStub classes, but leaves many other
> > classes which are not present in IcedTea6 (for example
> > java/util/Hashtable$EmptyEnumerator). In fact, a large changeset went
> > into OpenJDK7 to update this classlist [1]. As such, this part of
> > tools.patch is not necessary (otherwise we would see more build errors)
> > nor sufficient (since it leaves many other removed classes alone).
> >
> > The second part of the patch adds a phony target sources which is not
> > used anywhere.
> >
> > I have done a bootstrap build without a patches/tools.patch and I have
> > not seen any problems.
> >
> > Any thoughts on dropping the patch? Matthias, I see that this patch was
> > dropped once (icedtea6 changeset 2855ab5fe0e7) but you reverted it. Do
> > you know if the problems were caused by this patch, or was it one of the
> > other patches that was dropped?
> >
> > [1] http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/da5e33af0e61
> 
> Ping. Anyone have any thoughts?
> 
> Cheers,
> Omair

Drop it.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37